up(cli): support --version#2154
Closed
DonIsaac wants to merge 1 commit into
Closed
Conversation
CodSpeed Performance ReportMerging #2154 will not alter performanceComparing Summary
|
Member
|
The version should match Line 3 in 7f89bfe I think we need to compile it into the binary by supplying it in CI oxc/.github/workflows/release_oxlint.yml Line 41 in 7f89bfe |
Boshen
added a commit
that referenced
this pull request
Jan 26, 2024
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
Dunqing
pushed a commit
that referenced
this pull request
Oct 31, 2025
…ier names (#15035) feat(transformer): add warning for arbitrary module namespace identifier names Implements warnings for the ES2020 "Arbitrary module namespace identifier names" feature (TC39 proposal #2154), which allows string literals as import/export specifiers. Similar to #14276. ### Changes - **Compatibility data**: Added `ArbitraryModuleNamespaceNames` to `tasks/compat_data/custom-compat-data.js` with browser support (Chrome 88+, Edge 88+, Opera 74+, Firefox 87+, Safari 14.1+, Node 16.0+, Deno 1.6+) - **Transformer**: Added warning logic in `ES2020` for string literals in `ImportSpecifier`, `ExportSpecifier`, and `ExportAllDeclaration` nodes - **Configuration**: Added `arbitrary_module_namespace_names` option and environment target mapping ### Example ```javascript // Triggers warning when targeting ES2019 or Chrome 87 export { foo as "kebab-case-name" }; import { "string-name" as bar } from "./module"; export * as "namespace" from "./module"; ``` Warning message: ``` ⚠ Arbitrary module namespace identifier names are not available in the configured target environment. ``` ### Testing Added integration tests covering supported/unsupported targets, multiple literals, and normal identifiers. <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > Similar to #14276, add a warning for "Arbitrary module namespace identifier names" feature (tc39/ecma262#2154). Add the compat data to `tasks/compat_data/custom-compat-data.js` as the data is not included in the compat table. </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Signed-off-by: 翠 <green@sapphi.red> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com> Co-authored-by: 翠 <green@sapphi.red>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
--versionto all commands inoxc_cli. I've setoxc_cli's version to match the other packages in the monorepo (0.5.0). Let me know if you'd like the version set to some other value.