close
Skip to content

Store credentials provided through command line in macOS keychain#9847

Merged
i2h3 merged 1 commit into
masterfrom
i2h3/fix/9638-cli-creds
Apr 16, 2026
Merged

Store credentials provided through command line in macOS keychain#9847
i2h3 merged 1 commit into
masterfrom
i2h3/fix/9638-cli-creds

Conversation

@i2h3
Copy link
Copy Markdown
Collaborator

@i2h3 i2h3 commented Apr 16, 2026

Fixes #9638.

@i2h3 i2h3 added this to the 33.0.3 milestone Apr 16, 2026
@i2h3 i2h3 self-assigned this Apr 16, 2026
@i2h3 i2h3 requested a review from Aiiaiiio as a code owner April 16, 2026 10:32
@i2h3 i2h3 added the os: 🍎 macOS Apple macOS, formerly also known as OS X label Apr 16, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Apr 16, 2026
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Apr 16, 2026
@i2h3
Copy link
Copy Markdown
Collaborator Author

i2h3 commented Apr 16, 2026

/backport to stable-33.0

…keychain

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
@i2h3 i2h3 force-pushed the i2h3/fix/9638-cli-creds branch from 42fdc9b to 35cc263 Compare April 16, 2026 10:33
@github-actions
Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9847.zip

Digest: sha256:aa19366e2469ca20a335c7c8994d2f1670be60e904b3ec1ecf49f7f8e6f32bcb

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
BERJAYA C Maintainability Rating on New Code (required ≥ A)
BERJAYA 8 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

BERJAYA Catch issues before they fail your Quality Gate with our IDE extension BERJAYA SonarQube for IDE

@i2h3 i2h3 merged commit 997d2cc into master Apr 16, 2026
21 of 23 checks passed
@i2h3 i2h3 deleted the i2h3/fix/9638-cli-creds branch April 16, 2026 13:39
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Apr 16, 2026
@mgallien mgallien modified the milestones: 33.0.3, 34.0.0 Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Credentials not stored in Keychain after CLI Authentication

3 participants