close
Skip to content

fix(integration): only call parseEndpoints if fileId is not empty.#9701

Merged
mgallien merged 2 commits into
masterfrom
bugfix/noid/emptyfileid
Mar 26, 2026
Merged

fix(integration): only call parseEndpoints if fileId is not empty.#9701
mgallien merged 2 commits into
masterfrom
bugfix/noid/emptyfileid

Conversation

@camilasan
Copy link
Copy Markdown
Member

@camilasan camilasan commented Mar 25, 2026

When right clicking on a file and on File actions, the users was always seeing the error "The file ID is empty for ".

We can not control when QML instantiates the file id, but we can make sure the file id is not set to empty. For file provider the local path also needs to be validated.

@camilasan camilasan changed the title WIP: fix(integration): only call parseEndpoints if fileId is not empty. fix(integration): only call parseEndpoints if fileId is not empty. Mar 26, 2026
@camilasan camilasan marked this pull request as ready for review March 26, 2026 18:41
@camilasan camilasan force-pushed the bugfix/noid/emptyfileid branch from 3f2425b to 165e140 Compare March 26, 2026 18:42
@camilasan
Copy link
Copy Markdown
Member Author

/backport to stable-33.0

Signed-off-by: Camila Ayres <hello@camilasan.com>
… folder is found.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@mgallien mgallien enabled auto-merge March 26, 2026 20:44
@mgallien mgallien force-pushed the bugfix/noid/emptyfileid branch from 165e140 to b936a60 Compare March 26, 2026 20:44
@github-actions
Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9701.zip

Digest: sha256:19ac53b261b1865311ae8991cd2016458d6cd9288202ce786b0cc82166003399

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 1e9bcc5 into master Mar 26, 2026
20 of 21 checks passed
@mgallien mgallien deleted the bugfix/noid/emptyfileid branch March 26, 2026 21:20
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
BERJAYA D Maintainability Rating on New Code (required ≥ A)
BERJAYA 13 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

BERJAYA Catch issues before they fail your Quality Gate with our IDE extension BERJAYA SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants