close
Skip to content

fix(file-provider): use correct FP domain identifier for sync status check#9008

Merged
nilsding merged 1 commit into
masterfrom
bugfix/8990/vfs-status-mapping
Nov 4, 2025
Merged

fix(file-provider): use correct FP domain identifier for sync status check#9008
nilsding merged 1 commit into
masterfrom
bugfix/8990/vfs-status-mapping

Conversation

@nilsding
Copy link
Copy Markdown
Member

@nilsding nilsding commented Nov 3, 2025 •
edited
Loading

also added some docstrings to some QHash<>es dealing with account/file provider identifier to keep in mind what key is expected where

Fixes #8990

@nilsding nilsding added this to the 4.0.2 milestone Nov 3, 2025
@Rello Rello moved this to 🏗️ In progress in 💻 Desktop Clients team Nov 4, 2025
@nilsding nilsding force-pushed the bugfix/8990/vfs-status-mapping branch from 38a0df0 to 883aa56 Compare November 4, 2025 09:01
@nilsding nilsding marked this pull request as ready for review November 4, 2025 09:02
@nilsding
Copy link
Copy Markdown
Member Author

nilsding commented Nov 4, 2025

/backport to stable-4.0

@nilsding
fix(file-provider): use correct FP domain identifier for sync status …
d46bee6 
…check

also added some docstrings to some `QHash<>`ess dealing with
account/file provider identifier to keep in mind what key is expected
where

Fixes #8990

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding nilsding force-pushed the bugfix/8990/vfs-status-mapping branch from 883aa56 to d46bee6 Compare November 4, 2025 15:02
@nilsding nilsding enabled auto-merge November 4, 2025 15:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 4, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9008.zip

Digest: sha256:3d3784f1b09ee2019f6f56d64cbb25fba458a1c0eb36cce2d6218582b09d829f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
BERJAYA D Maintainability Rating on New Code (required ≥ A)
BERJAYA 3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

BERJAYA Catch issues before they fail your Quality Gate with our IDE extension BERJAYA SonarQube for IDE

@nilsding nilsding merged commit 66d6c67 into master Nov 4, 2025
21 of 23 checks passed
@nilsding nilsding deleted the bugfix/8990/vfs-status-mapping branch November 4, 2025 16:10
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Nov 4, 2025
@backportbot backportbot Bot mentioned this pull request Nov 4, 2025
Merged
@mgallien mgallien modified the milestones: 4.0.2, 4.1.0 Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i2h3 i2h3 i2h3 approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

Assignees

@nilsding nilsding

Labels

None yet

Projects

None yet

Milestone

33.0.0

Development

Successfully merging this pull request may close these issues.

[Bug]: inaccurate report of degraded connection

4 participants

@nilsding @i2h3 @mgallien @Rello