close
Skip to content

Prevent find widget from being cropped in AUX window#229001

Merged
bpasero merged 2 commits into
microsoft:mainfrom
juliapz:fix-227546-find-widget-cropped
Sep 19, 2024
Merged

Prevent find widget from being cropped in AUX window#229001
bpasero merged 2 commits into
microsoft:mainfrom
juliapz:fix-227546-find-widget-cropped

Conversation

@juliapz
Copy link
Copy Markdown
Contributor

@juliapz juliapz commented Sep 18, 2024

Fixes #227546

Steps to Reproduce:

  1. Open a text editor in the main window.
  2. Open the find widget and focus on it. Notice how the blue outline fully outlines the input box.
  3. Right-click the editor tab and select "Copy into New Window".
  4. In the new window, open the find widget and focus on it again.
Before After
image image

Copy link
Copy Markdown
Contributor

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems to work, and its fair that the ibwrapper would only take the size of the elements inside. But its not clear to me why the parent of ibwrapper exceeds this, maybe due to the border it sets.

@bpasero bpasero assigned bpasero and unassigned rebornix Sep 19, 2024
@bpasero bpasero added this to the September 2024 milestone Sep 19, 2024
@bpasero bpasero enabled auto-merge (squash) September 19, 2024 08:26
@bpasero bpasero merged commit 4f559cd into microsoft:main Sep 19, 2024
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor find widget cropped in AUX window

4 participants