close
Skip to content

Polish getting started page (fix #226991)#226994

Merged
bhavyaus merged 5 commits into
microsoft:mainfrom
PhantomPower82:fix-226991
Sep 13, 2024
Merged

Polish getting started page (fix #226991)#226994
bhavyaus merged 5 commits into
microsoft:mainfrom
PhantomPower82:fix-226991

Conversation

@PhantomPower82
Copy link
Copy Markdown
Contributor

Fix #226991: Add vertical-align: middle and remove top property.

Before:

Screenshot_20240829_010941

After:

Screenshot

.monaco-workbench .part.editor > .content .gettingStartedContainer .gettingStartedSlideCategories .featured-icon {
font-size: 20px;
padding-right: 8px;
position: relative;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property can be deleted or not since using position: relative without top: 3px works the same as position: static (default value) for the element itself (https://stackoverflow.com/a/13394093)

Copy link
Copy Markdown
Contributor

@NriotHrreion NriotHrreion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@vs-code-engineering vs-code-engineering Bot added this to the September 2024 milestone Sep 9, 2024
@bhavyaus bhavyaus merged commit dd25af5 into microsoft:main Sep 13, 2024
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the icons and texts in the Start container of Getting Started page vertically centered

4 participants