Unset grid span defaults with viewport states enabled#78709
Merged
Conversation
d3a395c to
76949fd
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +34 B (0%) Total Size: 8.18 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 76949fd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26492888361
|
andrewserong
approved these changes
May 28, 2026
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Nice polish, this is testing well for me!
In the following screengrab, I've set desktop to 2/1 for a paragraph, on tablet I've explicitly set it to span 1 column, and mobile it's left blank. All feel clear to me:
2026-05-28.14.58.02.mp4
🚀
26 tasks
cbravobernal
pushed a commit
that referenced
this pull request
Jun 1, 2026
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the release/23.3 branch to get it included in the next release: def6279 |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up from #78543.
When a column or row span is set on a grid child, and then a non-default viewport state is toggled, the span controls appear with their default value of "1", when in fact they have no viewport value set. If we want to set that value explicitly to 1, we're forced to change the value to something else and then back to 1 for it to apply.
This PR fixes the issue by removing those inaccurate defaults when viewport states are enabled.
Testing Instructions