Theme: Remove and prevent dependency grouping comments#78573
Merged
Conversation
|
Size Change: 0 B Total Size: 8.04 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
May 22, 2026
Member
Author
|
I did an AI-assisted scan of open pull requests with the "[Package] Theme" label for any proposed additions of these comments (i.e. which would conflict with these changes) and confirmed there are none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates ESLint configuration to include
@wordpress/themein the set of packages which explicitly do not use dependency grouping comments, and fixes existing issues.Why?
Code quality: Since #73616 the project no longer requires these comments, and we've been slowly chipping away at them, but have no enforcement to actually prevent any new additions in the package. Without tooling feedback, AI agents are likely to adopt the convention seen through the codebase (i.e. add new docblocks). #74990 added an option to the dependency comments rule to forbid their usage and fix issues with an auto-fixer, but it is currently only applied to a couple packages.
How?
tools/eslint/config.mjs, where existing packages already enforce this rulenpm run lint:js:fix(there's an autofixer included in the rule)Testing Instructions
Verify no instances of dependency grouping comments in the package, and that
npm run lint:jsis clean.Use of AI Tools
No AI was used.