Compose: Simplify subscribeDelegatedListener root detection#78492
Merged
Conversation
`( target as Node ).ownerDocument ?? target` covers all three cases: Element → its document, Document → itself (its `ownerDocument` is null), Window → itself (no `ownerDocument` property). Replaces the three-branch `getRoot` function and avoids cross-realm `instanceof` hazards too. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Single property read gives us both the root and the window-vs-document distinction: - `Element.ownerDocument` → the Document (truthy → use as root) - `Document.ownerDocument` → `null` (falsy → root is target) - `Window.ownerDocument` → `undefined` (falsy → root is target) `isWindow` is just `ownerDoc === undefined`. Avoids the separate `.window === target` duck-typing check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -23 B (0%) Total Size: 7.98 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 775815d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26211669533
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #78310. Simplifies the root-detection logic in
subscribeDelegatedListener:getRootwith a one-line nullish coalesce —( target as Node ).ownerDocument ?? targetcovers all three cases: Element → its document, Document → itself (itsownerDocumentisnull), Window → itself (noownerDocumentproperty). Avoids the cross-realminstanceofhazards too.isWindowfrom the sameownerDocumentaccess —Window.ownerDocumentisundefined, soownerDoc === undefineddistinguishes Window from Document without a separate.window === targetduck-typing check.Why?
The previous three-branch
getRoot(Document vianodeType === 9, Window via.window === target, Element fallback) was correct but verbose. The singleownerDocumentproperty access encodes the same information across all three cases.How?
Testing Instructions
npx jest --config test/unit/jest.config.js --testPathPattern='subscribe-delegated-listener'— verifies dispatch behaviour across Element / Document / Window subscribers and cross-realm iframe.Use of AI Tools
Authored with Claude Code assistance; reviewed and verified by the author.