Fixed additional issues with block registration types#78416
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I'm not particularly pleased with how I had to implement the separate type for block settings parameter, so although it shouldn't break any existing properties, it might be worth it to split that into a separate PR. |
There was a problem hiding this comment.
Oh. Shoot. It's not strictly related - I just couldn't get anything to build until I ran npm up and then accidentally committed it after I ran the command to update the readme. TypeScript was giving me errors that implied that the version of ajv being loaded was horribly out of date.
(I've removed it)
464b139 to
0617cc5
Compare
ramonjd
left a comment
There was a problem hiding this comment.
Just left a non-blocking question about the & { name?: unknown } and potential typing looseness.
Thanks!!

What?
Closes #78415
Updates the types to match what is missing.
Why?
The types are currently incorrect.
How?
Testing Instructions
Use of AI Tools