Editor: Inline text editor toolbar z-index#78309
Merged
Merged
Conversation
|
Size Change: +32 B (0%) Total Size: 7.96 MB 📦 View Changed
ℹ️ View Unchanged
|
mirka
commented
May 14, 2026
| .editor-text-editor { | ||
| @include reset; | ||
| position: relative; | ||
| isolation: isolate; |
Member
Author
There was a problem hiding this comment.
The current stacking context is a relatively nearby ancestor (.interface-interface-skeleton__content), but I'll go ahead and add isolation right here for clarity, since I'm pretty confident it's safe to do so here.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 88d4826. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25879994727
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Inlines the text editor toolbar z-index value and removes the now-unused shared z-index map entry.
Why?
This z-index is only used by the text editor toolbar, so keeping it in the shared z-index map adds indirection without coordinating with other layers.
How?
editor-text-editor__toolbarentry from the shared z-index map.z-index: 1in the text editor stylesheet.isolation: isolateto the text editor wrapper so the toolbar's z-index is scoped to the text editor.Testing Instructions
Screenshots or screencast