Refactor validation tools and update related scripts by kushagra-goyal-14 · Pull Request #77522 · WordPress/gutenberg

kushagra-goyal-14 · 2026-04-21T12:49:25Z

What?

Why?

The issue provides more context, but in short, this PR ensures the workspace package does not rely on root dependencies once dependency isolation is enforced.

How?

This PR converts validation tools into a new workspace @wordpress/validation-tools while still relating the functionality.

Testing Instructions

Testing Instructions for Keyboard

npm run lint:lockfile
npm run lint:tsconfig
npm run other:check-local-changes
npm run other:check-licenses

or

npm run lint

…cripts

github-actions · 2026-04-22T06:22:39Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kushagra-goyal-14 <kush123@git.wordpress.org>
Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

…warding

kushagra-goyal-14 · 2026-04-22T16:36:57Z

Hi @manzoorwanijk
I've addressed the argument issue flagged in #77063 (comment). Could you take a look and let me know if anything was missed or needs further adjustment?

manzoorwanijk · 2026-04-22T16:40:58Z

~~As I mentioned in the reported PR, I already have a simpler fix for it - #77541~~

EDIT: Never mind. I thought this PR is trying to fix that same issue.

manzoorwanijk · 2026-04-22T16:43:19Z

Could you take a look and let me know if anything was missed or needs further adjustment?

Thanks. I’ll have a look at this soon.

manzoorwanijk

Thank you for working on this. Let us tidy things a bit.

manzoorwanijk · 2026-04-22T16:54:15Z

+		"ajv": "8.17.1",
+		"chalk": "4.1.1",
+		"cross-spawn": "^7.0.6",
+		"glob": "7.1.2",
+		"jsonc-parser": "3.3.1",
+		"simple-git": "3.24.0"


Let us use the version ranges here and remove the deps that are not used in the workspace.

Suggested change

"ajv": "8.17.1",

"chalk": "4.1.1",

"cross-spawn": "^7.0.6",

"glob": "7.1.2",

"jsonc-parser": "3.3.1",

"simple-git": "3.24.0"

"chalk": "^4.1.1",

"glob": "^7.1.2",

"jsonc-parser": "^3.3.1",

"simple-git": "^3.24.0"

manzoorwanijk · 2026-04-22T16:57:20Z

 	collectDeps,
 	readPackageJson,
-} from '../packages/scripts/utils/license.js';
+} from '../../packages/scripts/utils/license.js';


Let us add @wordpress/scripts as a dev dependency to this workspace and the use @wordpress/scripts/utils/license.js here.

manzoorwanijk · 2026-04-22T16:58:16Z

+		"gutenberg",
+		"api-docs"
+	],
+	"homepage": "https://github.com/WordPress/gutenberg/tree/HEAD/tools/validation/README.md",


The README doesn't exist.

manzoorwanijk · 2026-04-22T16:58:51Z

+	"keywords": [
+		"wordpress",
+		"gutenberg",
+		"api-docs"


This keyword doesn't seem to be relevant.

manzoorwanijk · 2026-04-22T17:00:53Z

 		"test/unit",
-		"tools/api-docs"
+		"tools/api-docs",
+		"tools/validation"


Once you update this branch from trunk, you won't need this change here.

manzoorwanijk · 2026-04-22T17:04:48Z

+		"lint:lockfile": "npm run validate-package-lock --workspace @wordpress/validation-tools --",
+		"lint:tsconfig": "npm run validate-tsconfig --workspace @wordpress/validation-tools --",


It's better to have --workspace argument before the other arguments, just in case the script accepts arguments.

manzoorwanijk · 2026-04-22T17:18:30Z

@@ -0,0 +1,42 @@
+{
+	"name": "@wordpress/validation-tools",
+	"version": "1.0.0",


Let us use version 0

Suggested change

"version": "1.0.0",

"version": "0.0.0",

manzoorwanijk · 2026-05-08T19:01:01Z

This needs to be updated from trunk

- Refactor linting commands in package.json to use the new npm run syntax for workspaces. - Update check-licenses script to import dependencies from @wordpress/scripts. - Change version of @wordpress/validation-tools to 0.0.0 in package.json. - Modify validate-package-lock.js to correctly resolve the package-lock.json path. - Fix tsconfig validation to use JSONC parser for reading tsconfig.json.

…ge.json

kushagra-goyal-14 · 2026-05-11T10:49:30Z

This needs to be updated from trunk

Done

manzoorwanijk

This looks very close. Let us try to reduce the number of changes in check-licenses.mjs to try preserving its git history.

manzoorwanijk · 2026-05-12T11:00:38Z

-/*
- * This script checks licenses for production dependencies of packages that are
- * shipped with WordPress (those with wpScript or wpScriptModuleExports in package.json).
- *
- * It works independently of the package manager (npm, pnpm, etc.) by:
- * 1. Reading package.json files to find wpScript packages
- * 2. Reading their production dependencies
- * 3. Resolving each dependency using Node's module resolution
- * 4. Reading the license from each resolved package
- */


Let us not remove this comment please.

Replace bin/packages/validate-typescript-version.js with a generic install-drift check that catches stale node_modules from any dependency, not just typescript. The new script (tools/validation/check-installed-deps.mjs) compares package-lock.json against npm's hidden lockfile (node_modules/.package-lock.json) and verifies installed integrity per registry-fetched entry, ignoring workspace links and platform-skipped optional deps. Set up tools/validation/ as a workspace (@wordpress/validation-tools, picked up by the existing tools/* glob). Build, dev, and build:profile-types invoke the check via `npm run check-installed-deps --workspace @wordpress/validation-tools`. Aligns with the validation-tools workspace direction from #77522 and Also extends the CLI/bin/env eslint override (no-console: off) to cover tools/validation/**, mirroring the same change in #77522.

manzoorwanijk · 2026-05-13T15:20:58Z

We now have tools/validation/package.json in trunk. So let us update the PR from trunk

… add license checking script

manzoorwanijk

This is so close. Thank you for the changes.

Let us clean things up a bit before we can merge this

manzoorwanijk · 2026-05-14T08:28:10Z

 	"bugs": {
 		"url": "https://github.com/WordPress/gutenberg/issues"
 	},
-	"type": "module",


Why are we removing this? If any .js file errs, we can change the extention to .cjs.

Oh right! I missed that there are two CommonJS files, validate-package-lock.js and check-local-changes.js. It's better to keep "type": "module" and rename the files to .cjs instead. Thanks (Updated after edit)

manzoorwanijk · 2026-05-14T08:28:45Z

+	"engines": {
+		"node": ">=20.10.0"
+	},


We don't really need the engines field here because this lives only in the monorepo.

manzoorwanijk · 2026-05-14T08:29:48Z

+		"check-installed-deps": "node ./check-installed-deps.mjs",
+		"check-licenses": "node ./check-licenses.mjs",
+		"validate-package-lock": "node ./validate-package-lock.js",
+		"validate-tsconfig": "node ./validate-tsconfig.mjs",
+		"check-local-changes": "node ./check-local-changes.js"


Let us sort these alphabetically

Suggested change

"check-installed-deps": "node ./check-installed-deps.mjs",

"check-licenses": "node ./check-licenses.mjs",

"validate-package-lock": "node ./validate-package-lock.js",

"validate-tsconfig": "node ./validate-tsconfig.mjs",

"check-local-changes": "node ./check-local-changes.js"

"check-installed-deps": "node ./check-installed-deps.mjs",

"check-licenses": "node ./check-licenses.mjs",

"check-local-changes": "node ./check-local-changes.js",

"validate-package-lock": "node ./validate-package-lock.js",

"validate-tsconfig": "node ./validate-tsconfig.mjs"

manzoorwanijk · 2026-05-14T08:32:01Z

+			'tools/validation/**/*.js',
+			'tools/validation/**/*.mjs',


We don't need this, it's already covered by tools/** above

Suggested change

'tools/validation/**/*.js',

'tools/validation/**/*.mjs',

@manzoorwanijk The linting tests are failing because the current tools/**/*.js and tools/**/*.mjs patterns don't cover .cjs files. Since there are only two cjs files in validation, should I add tools/**/*.cjs to the pattern, or would using eslint-disable-next-line no-console comments be a good idea here?

Then we can add tools/**/*.cjs there.

…cript

…tension

manzoorwanijk

Thank you for making the requested changes. This looks good now.

kushagra-goyal-14 added 4 commits April 21, 2026 18:05

refactor: move validation tools to workspace and update scripts

a8f85ed

refactor: clean up formatting and improve readability in validation s…

c599f1d

…cripts

feat: add validation tool patterns to ESLint configuration

644df70

fix: correct pattern for validation tool files in ESLint configuration

acbfdd1

kushagra-goyal-14 marked this pull request as ready for review April 22, 2026 06:22

kushagra-goyal-14 requested review from ajitbohra, nerrad and ntwb as code owners April 22, 2026 06:22

fix: update validation tool commands in package.json for argument for…

42d3ec6

…warding

manzoorwanijk requested changes Apr 22, 2026

View reviewed changes

t-hamano added the [Type] Build Tooling Issues or PRs related to build tooling label Apr 27, 2026

manzoorwanijk mentioned this pull request May 3, 2026

Idea: Clean up root package.json and convert tools and tests to workspace packages #75041

Open

35 tasks

kushagra-goyal-14 and others added 6 commits May 11, 2026 12:26

Merge branch 'trunk' into try/migrate-validation-tools-to-workspace

3354417

Merge branch 'trunk' into try/migrate-validation-tools-to-workspace

f663995

chore: update validation tools version to 0.0.0

b6d4b56

chore: migrate license check script from .mjs to .js and update packa…

a1fa693

…ge.json

Merge branch 'trunk' into try/migrate-validation-tools-to-workspace

b5f7ba5

kushagra-goyal-14 requested a review from manzoorwanijk May 11, 2026 10:53

manzoorwanijk requested changes May 12, 2026

View reviewed changes

manzoorwanijk reviewed May 13, 2026

View reviewed changes

kushagra-goyal-14 mentioned this pull request May 13, 2026

Fix path for license type detection in license.js #78245

Merged

Merge branch 'trunk' into try/migrate-validation-tools-to-workspace

72d4e64

kushagra-goyal-14 and others added 3 commits May 14, 2026 12:37

Merge branch 'trunk' into try/migrate-validation-tools-to-workspace

862002b

Migrate validation tools to workspace: remove unused dependencies and…

5713ea5

… add license checking script

Remove unused validation tool dependency from package-lock.json

2ad010f

kushagra-goyal-14 requested a review from manzoorwanijk May 14, 2026 08:13

manzoorwanijk requested changes May 14, 2026

View reviewed changes

kushagra-goyal-14 and others added 5 commits May 14, 2026 15:03

Remove unused validation tool paths and add package-lock validation s…

53ccdf2

…cript

Add check-local-changes script and update package.json to use .cjs ex…

694c53d

…tension

chore: remove engines field from package-lock.json

ee460ae

fix: add support for .cjs files in ESLint configuration

9bc623c

Merge branch 'trunk' into try/migrate-validation-tools-to-workspace

2b0c441

kushagra-goyal-14 requested a review from manzoorwanijk May 14, 2026 10:49

Merge branch 'trunk' into try/migrate-validation-tools-to-workspace

1646dc9

manzoorwanijk approved these changes May 14, 2026

View reviewed changes

manzoorwanijk merged commit f9a5024 into WordPress:trunk May 14, 2026
40 checks passed

github-actions Bot added this to the Gutenberg 23.3 milestone May 14, 2026

		"lint:lockfile": "npm run validate-package-lock --workspace @wordpress/validation-tools --",
		"lint:tsconfig": "npm run validate-tsconfig --workspace @wordpress/validation-tools --",

Conversation

kushagra-goyal-14 commented Apr 21, 2026

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kushagra-goyal-14 commented Apr 22, 2026

Uh oh!

manzoorwanijk commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manzoorwanijk commented Apr 22, 2026

Uh oh!

manzoorwanijk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk commented May 8, 2026

Uh oh!

kushagra-goyal-14 commented May 11, 2026

Uh oh!

manzoorwanijk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kushagra-goyal-14 May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 22, 2026 •

edited

Loading

manzoorwanijk commented Apr 22, 2026 •

edited

Loading

kushagra-goyal-14 May 14, 2026 •

edited

Loading