close
Skip to content

fix: dashboard flaking#4051

Merged
universalmind303 merged 1 commit into
mainfrom
cory/dashboard-flake
Mar 25, 2025
Merged

fix: dashboard flaking#4051
universalmind303 merged 1 commit into
mainfrom
cory/dashboard-flake

Conversation

@universalmind303
Copy link
Copy Markdown
Member

@universalmind303 universalmind303 commented Mar 24, 2025

Summary

the rerun-if-changed was incorrect, so it was always rebuilding, so if you had rust-analyzer or anything else running in the background, it was thrashing the .next directory, causing the flakes.

closes #4049

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.25%. Comparing base (3be3321) to head (6f030a1).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4051      +/-   ##
==========================================
- Coverage   78.45%   78.25%   -0.20%     
==========================================
  Files         783      783              
  Lines      100062    99451     -611     
==========================================
- Hits        78499    77826     -673     
- Misses      21563    21625      +62     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@universalmind303 universalmind303 merged commit 4cae0b7 into main Mar 25, 2025
@universalmind303 universalmind303 deleted the cory/dashboard-flake branch March 25, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky failures when building daft-dashboard

2 participants