Add filters to override Shib-provided username and email#74
Merged
jrchamp merged 4 commits intoAug 27, 2021
Merged
Conversation
jrchamp
reviewed
Jul 21, 2021
Collaborator
jrchamp
left a comment
There was a problem hiding this comment.
I noticed a couple of spaces that might be extra, but as long as this works for your use case, it seems reasonable to me.
jrchamp
approved these changes
Jul 21, 2021
Collaborator
jrchamp
left a comment
There was a problem hiding this comment.
Approving, as these filters provide an important opportunity for a WordPress administrator to meet their needs. For a malicious user to abuse these, they would need to be able to inject custom hooks, which is already possible in core WordPress (thus, no change).
Before merging, I will tag @michaelryanmcneill to see if there are other considerations that I am not thinking of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue 73, this PR adds filters to override the Shib-provided username and email address. There's also a warning that this is, in the general sense, a Bad Idea. Please squash these commits before merging, I'm bad at Git.
Resolves #73