close
The Wayback Machine - https://web.archive.org/web/20230124062737/https://github.com/WordPress/performance/pull/404
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on wp_get_image_editor() methods argument to check whether it supports dominant color methods #404

Merged
merged 3 commits into from Jul 6, 2022
Merged

Rely on wp_get_image_editor() methods argument to check whether it supports dominant color methods #404

merged 3 commits into from Jul 6, 2022

Conversation

spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Jun 29, 2022 •
edited

Summary

wp_get_image_editor has a method to allow to check to see if method exists. Also editors to workout if mime type is supported.

Fixes #

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@spacedmonkey spacedmonkey self-assigned this Jun 29, 2022
@spacedmonkey spacedmonkey requested a review from pbearne as a code owner Jun 29, 2022
@spacedmonkey spacedmonkey added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images Issues related to the Images focus area [Module] Dominant Color Issues for the Dominant Color module labels Jun 29, 2022
@spacedmonkey spacedmonkey added this to Backlog in [Focus] Images via automation Jun 29, 2022
@spacedmonkey spacedmonkey requested a review from felixarntz Jul 5, 2022
@spacedmonkey spacedmonkey mentioned this pull request Jul 5, 2022
Open
pbearne
pbearne approved these changes Jul 5, 2022
View changes
Copy link
Contributor

@pbearne pbearne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@bethanylang bethanylang added the Needs Review Anything that requires code review label Jul 5, 2022
@bethanylang bethanylang moved this from Backlog to Review in [Focus] Images Jul 5, 2022
adamsilverstein
adamsilverstein approved these changes Jul 6, 2022
View changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@spacedmonkey spacedmonkey added this to the 1.3.0 milestone Jul 6, 2022
@spacedmonkey spacedmonkey merged commit 654157b into trunk Jul 6, 2022
5 checks passed
[Focus] Images automation moved this from Review to Done Jul 6, 2022
@spacedmonkey spacedmonkey deleted the try/improve-params branch Jul 6, 2022
@felixarntz felixarntz changed the title Move check. Rely on wp_get_image_editor() methods argument to check whether it supports dominant color methods Jul 6, 2022
@ShadowXVII ShadowXVII mentioned this pull request Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbearne pbearne

@adamsilverstein adamsilverstein

@felixarntz felixarntz

Assignees

@spacedmonkey spacedmonkey

Labels
[Focus] Images Issues related to the Images focus area [Module] Dominant Color Issues for the Dominant Color module Needs Review Anything that requires code review [Type] Enhancement A suggestion for improvement of an existing feature
Projects
[Focus] Images
Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spacedmonkey @pbearne @adamsilverstein @bethanylang