Limit "tootctl accounts follow" to local accounts#11592
Merged
Conversation
75e293c to
e0c4864
Compare
Contributor
Author
|
Oops, gonna fix those quotes. |
To (somewhat) limit mass remote follow. Fix mastodon#11360
e0c4864 to
06dbd8e
Compare
Gargron
approved these changes
Aug 17, 2019
mayaeh
pushed a commit
to mastodon-ja-l10n-team/mastodon
that referenced
this pull request
Aug 18, 2019
To (somewhat) limit mass remote follow. Fix mastodon#11360
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
To (somewhat) limit mass remote follow. Fix mastodon#11360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To (somewhat) limit mass remote follow: #11360.
I don't know if the code is good, I figured it's the simplest way to prevent remote follows.
But after all, the code is already out there. So "attackers" can modify this file themselves, make their own fork, not update, revert this commit, etc. It does not actually fix this mass follow issue.
But is this feature actually useful in the first place? I mean it is useful for local accounts, but I don't see why an admin would force a remote follow.
Anyway I made this PR for fun so feel free to discard it ✌️