let bundler fetch http_parser.rb submodules#11444
Merged
Conversation
Author
|
I think the build failure is not related to my changes. |
Member
|
No, it is related: |
Author
|
It was failing with a different, unrelated error first (fuubar 2.4.0 could not be fetched). Now I rebased on master and it gives this different error. I will look into it later. |
shleeable
reviewed
Jul 29, 2019
Author
|
The build failure was caused by the whitespace error @Shleeble found, now the build passes. |
Gargron
approved these changes
Jul 29, 2019
20 tasks
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motavation for this change:
The http_parser.rb gem uses git submodules and fetches them during the build. In situations where the dependencies for mastodon are fetched upfront, and a network connection is intentionally unavailable during the build, this will make the http_parser.rb gem build fail.
This is the case when packaging Mastodon with the Nix package manager.
Adding the submodules attribute makes bundler fetch the submodules upfront instead of them being fetched during the build process.