close
Skip to content

let bundler fetch http_parser.rb submodules#11444

Merged
Gargron merged 1 commit into
masterfrom
unknown repository
Jul 29, 2019
Merged

let bundler fetch http_parser.rb submodules#11444
Gargron merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 29, 2019

Motavation for this change:

The http_parser.rb gem uses git submodules and fetches them during the build. In situations where the dependencies for mastodon are fetched upfront, and a network connection is intentionally unavailable during the build, this will make the http_parser.rb gem build fail.
This is the case when packaging Mastodon with the Nix package manager.
Adding the submodules attribute makes bundler fetch the submodules upfront instead of them being fetched during the build process.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 29, 2019

I think the build failure is not related to my changes.

@Gargron
Copy link
Copy Markdown
Member

Gargron commented Jul 29, 2019

No, it is related:

The git source https://github.com/tmm1/http_parser.rb is not yet checked out. Please run `bundle install` before trying to start your application

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 29, 2019

It was failing with a different, unrelated error first (fuubar 2.4.0 could not be fetched). Now I rebased on master and it gives this different error. I will look into it later.

Comment thread Gemfile.lock Outdated
@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 29, 2019

The build failure was caused by the whitespace error @Shleeble found, now the build passes.

@Gargron Gargron merged commit 658277b into mastodon:master Jul 29, 2019
@ghost ghost mentioned this pull request Aug 26, 2019
20 tasks
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants