Test that you can't implement Unpin for a compiler-generated future using TAIT#157069
Open
Darksonn wants to merge 1 commit into
Open
Test that you can't implement Unpin for a compiler-generated future using TAIT#157069Darksonn wants to merge 1 commit into
Darksonn wants to merge 1 commit into
Conversation
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
7023463 to
307310c
Compare
RalfJung
reviewed
May 29, 2026
Comment on lines
+19
to
+20
| impl Unpin for MyFut {} | ||
| //~^ ERROR: only traits defined in the current crate can be implemented for arbitrary types |
Member
Member
Author
There was a problem hiding this comment.
All compiler-generated futures should probably come with an implicit impl !Unpin so that this doesn't rely on orphan rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came up with this while trying to break pinning. Seems like a good idea to have a test that this doesn't change.
r? @RalfJung