close
Skip to content

update TargetFeature::Forbidden docs#157059

Open
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:forbidden-target-features
Open

update TargetFeature::Forbidden docs#157059
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:forbidden-target-features

Conversation

@RalfJung
Copy link
Copy Markdown
Member

That comment was a bit outdated, I think I wrote it before abi_required_features existed.

r? @workingjubilee
Cc @wesleywiser

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 28, 2026

workingjubilee is currently at their maximum review capacity.
They may take a while to respond.

Comment thread compiler/rustc_target/src/target_features.rs Outdated
@rust-log-analyzer

This comment has been minimized.

@RalfJung RalfJung force-pushed the forbidden-target-features branch from 1dc023e to 9d63521 Compare May 28, 2026 21:45
@RalfJung RalfJung force-pushed the forbidden-target-features branch from 9d63521 to 375c51c Compare May 28, 2026 21:46
@workingjubilee
Copy link
Copy Markdown
Member

maybe we should enforce that those kinds of links are in the format that can be moved into a doc comment even if... nahhh that's too silly.

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
...............................F.................. (50/143)
.................................................. (100/143)
...........................................        (143/143)

======== tests/rustdoc-gui/go-to-collapsed-elem.goml ========

[ERROR] line 40
    at `tests/rustdoc-gui/go-to-collapsed-elem.goml` line 21: Error: Node is detached from document: for command `click: "//*[@id='search']//a[@href='../test_docs/struct.Foo.html#method.must_use']"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.Foo.html?search=t_use>


<= doc-ui tests done: 142 succeeded, 1 failed, 0 filtered out

Error: ()

@workingjubilee
Copy link
Copy Markdown
Member

...I really don't think that's your fault.

@workingjubilee
Copy link
Copy Markdown
Member

gonna try and see if we can get a clean run

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2026
@RalfJung
Copy link
Copy Markdown
Member Author

...I really don't think that's your fault.

Yeah that's #93784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants