close
Skip to content

docs: make Rc::into_raw clickable in Rc::increment_strong_count doc#156783

Open
MingweiSamuel wants to merge 3 commits into
rust-lang:mainfrom
MingweiSamuel:patch-2
Open

docs: make Rc::into_raw clickable in Rc::increment_strong_count doc#156783
MingweiSamuel wants to merge 3 commits into
rust-lang:mainfrom
MingweiSamuel:patch-2

Conversation

@MingweiSamuel
Copy link
Copy Markdown
Contributor

@MingweiSamuel MingweiSamuel commented May 20, 2026

adds doc link

Copilot AI review requested due to automatic review settings May 20, 2026 17:50
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 20, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 7 candidates

This comment was marked as low quality.

Sign in to view

joboet
joboet reviewed May 21, 2026
View reviewed changes
Comment thread library/alloc/src/rc.rs Outdated
@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented May 27, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 27, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

MingweiSamuel
MingweiSamuel commented May 27, 2026
View reviewed changes
Comment thread library/alloc/src/rc.rs Outdated
@MingweiSamuel @joboet
remove explicit doc linking
b097ed1 
Co-authored-by: Jonas Böttiger <jonasboettiger@icloud.com>
Co-authored-by: Mingwei Samuel <mingwei.samuel@gmail.com>
MingweiSamuel
MingweiSamuel commented May 27, 2026
View reviewed changes
Comment thread library/alloc/src/rc.rs Outdated
@MingweiSamuel
Copy link
Copy Markdown
Contributor Author

MingweiSamuel commented May 27, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarfonthey clarfonthey clarfonthey left review comments

@joboet joboet joboet left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MingweiSamuel @rustbot @jieyouxu @clarfonthey @joboet @Mark-Simulacrum