Suggest importable type that differs slightly#156239
Draft
GTimothy wants to merge 19 commits into
Draft
Conversation
Co-authored-by: Chris Simpkins <git.simpkins@gmail.com>
adds a is_exact_match field to ImportSuggestion that is unused for now. suggestions now include 1-edit variations as suggestions
36cee45 to
a23f444
Compare
Contributor
Author
|
I see from the 247 failed tests that 1-edit difference is too big for small names. 'net' should probably NOT be suggested to replace 'new'... Edit: i have now switched to case insensitive match only. |
This comment has been minimized.
This comment has been minimized.
bless customized help message undo blessing a bad suggestion test stderr moved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR proposes to propose case insensitive import suggestions.
Previous discussion of this topic here: #72641 and in this PR: #72988
If that is still of interest, a discussion may be needed to limit or expand the included list.
I initially followed the suggestions in #72988.
The tests are based on the tests by @chrissimpkins in #72988.
I added a
is_exact_matchfield toImportSuggestionto eventually modify the suggestion text accordingly.Only when no other suggestion is made, do I check for case insensitive import suggestion.
for a more complex case:
SystemTimeexists in the stdlib, but I only suggest case insensitive import when nothing else is suggestedThe work also checks for expected parameter counts to avoid suggesting incompatible types.