chore: fix setup script errors#146729
Open
zkpepe wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @marcoieni rustbot has assigned @marcoieni. Use |
marcoieni
reviewed
Sep 25, 2025
Comment on lines
+9
to
+11
| # Check and set default values for variables | ||
| : "${MIRRORS_BASE:?MIRRORS_BASE is not set}" | ||
| : "${RUST_CONFIGURE_ARGS:=}" |
Member
There was a problem hiding this comment.
Suggested change
| # Check and set default values for variables | |
| : "${MIRRORS_BASE:?MIRRORS_BASE is not set}" | |
| : "${RUST_CONFIGURE_ARGS:=}" | |
| # Fail is variable is not set | |
| : "${MIRRORS_BASE:?MIRRORS_BASE is not set}" | |
| # Set the variable to an empty string if it's undefined | |
| : "${RUST_CONFIGURE_ARGS:=}" |
Member
|
Thanks, this looks good, I just left a small improvements for the comment. |
Member
|
@zkpepe Hi, ping from triage team. This PR has been inactive for a while. There is still a review comments that needs to be addressed. Would you like to proceed with this PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

made the setup script more reliable:
MIRRORS_BASEnow errors if missing.RUST_CONFIGURE_ARGSdefaults to empty.mkdir -p ninjaavoids “already exists” errors.curl -fLofollows redirects and fails on HTTP errors.simple, clear, and it just works.