close
Skip to content

Add temporary scope to assert_eq and assert_ne#155739

Open
Voultapher wants to merge 1 commit into
rust-lang:mainfrom
Voultapher:add-tmp-scope-to-assert-macros
Open

Add temporary scope to assert_eq and assert_ne#155739
Voultapher wants to merge 1 commit into
rust-lang:mainfrom
Voultapher:add-tmp-scope-to-assert-macros

Conversation

@Voultapher
Copy link
Copy Markdown
Contributor

@Voultapher Voultapher commented Apr 24, 2026

View all comments

This is a follow-up to #155431

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 24, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@Voultapher
Copy link
Copy Markdown
Contributor Author

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned joboet Apr 24, 2026
@Voultapher
Copy link
Copy Markdown
Contributor Author

This constitutes a desired breaking library change as per #154406 (comment). Will need a crater run.

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Apr 24, 2026

@bors try

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Apr 24, 2026
…<try>

Add temporary scope to assert_eq and assert_ne
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

☀️ Try build successful (CI)
Build commit: 3383500 (33835004928d3bf65db4d4712e1330766263b0bd, parent: ec6f9a5b4413f74386267ef8efc93712c2ce6db6)

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Apr 24, 2026

@craterbot test

@craterbot
Copy link
Copy Markdown
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Apr 24, 2026

@craterbot run mode=check

@craterbot
Copy link
Copy Markdown
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 25, 2026

@craterbot check

@craterbot
Copy link
Copy Markdown
Collaborator

👌 Experiment pr-155739 created and queued.
🤖 Automatically detected try build 3383500
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2026
@theemathas
Copy link
Copy Markdown
Contributor

@Kivooeo This can impact run time behavior via drop order, so this needs a check-and-test

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 25, 2026

To be perfectly honest, I had the same initial thought, but I trusted Amanieu and did what they have been trying to do before

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Apr 25, 2026

I considered a test run, but in the end I think it's very unlikely that we will catch anything.

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Apr 25, 2026

On second thought let's just make this a test run.

@craterbot cancel

@craterbot
Copy link
Copy Markdown
Collaborator

🗑️ Experiment pr-155739 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 25, 2026
@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Apr 25, 2026

@craterbot run mode=build-and-test

@craterbot
Copy link
Copy Markdown
Collaborator

👌 Experiment pr-155739 created and queued.
🤖 Automatically detected try build 3383500
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2026
@craterbot
Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-155739 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-155739 is completed!
📊 403 regressed and 396 fixed (907190 total)
📊 52455 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-155739/retry-regressed-list.txt

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 13, 2026
@theemathas
Copy link
Copy Markdown
Contributor

The FUMI-FF.rusted_c regression looks legitimate. Let's rerun crater to whittle down the number of test failures we have to look through.

@craterbot run mode=build-and-test crates=https://crater-reports.s3.amazonaws.com/pr-155739/retry-regressed-list.txt p=1

@craterbot
Copy link
Copy Markdown
Collaborator

👌 Experiment pr-155739-1 created and queued.
🤖 Automatically detected try build 3383500
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2026
@craterbot
Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-155739-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-155739-1 is completed!
📊 106 regressed and 91 fixed (52545 total)
📊 1528 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-155739-1/retry-regressed-list.txt

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 15, 2026
@Voultapher
Copy link
Copy Markdown
Contributor Author

The only compile regression seems to be FUMI-FF.rusted_c test wise I looked at some of the ~100 remaining and they all looked like spurious failures which I couldn't reproduce and seem unrelated.

@Voultapher
Copy link
Copy Markdown
Contributor Author

@Amanieu any thoughts on how to proceed?

@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented May 28, 2026

I think the impact is low enough that we do want to go through with this.

@rfcbot merge libs-api

@rust-rfcbot
Copy link
Copy Markdown
Collaborator

rust-rfcbot commented May 28, 2026

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants