Preserve environment variables explicitly passed to Context.sudo.#845
Merged
Merged
Conversation
sudo, by default, will not pass environment variables from the context in which it is invoked to the context in creates to run actual commands in. This is almost certainly the correct thing to do but unfortunately also means that any environment variables that are explicitly passed via the env= kwarg also get removed. This change adds a --preserve-env= argument to the internal sudo invocation that will ensure that arguments passed via the env= kwarg are presented to the interior command while still ensuring that the rest of the outer environment stays outside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudo, by default, will not pass environment variables from the context in which it is invoked to the context in creates to run actual commands in. This is almost certainly the correct thing to do but unfortunately also means that any environment variables that are explicitly passed via the env= kwarg also get removed.
This change adds a --preserve-env= argument to the internal sudo invocation that will ensure that arguments passed via the env= kwarg are presented to the interior command while still ensuring that the rest of the outer environment stays outside.