make Collection subclassable#342
Merged
Merged
Conversation
Current coverage is
|
Member
|
Thanks, that's an oversight/bug for sure, adding to milestone :) |
Member
|
Years later...sob...merged this & made sure it played nice with how the code changed in the interim. (tl;dr we moved things around & are using an inner closure, but were still hardcoding |
Contributor
Author
|
Great! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I would like to extend the invoke.Collection class by subclassing it. But the from_module method in the current version will always return the original class. This little patch has no influence on the API, is cleaner, and would make me happy :-)