fix(compiler): Correct type printing of type A<a> = a#2302
Merged
Conversation
ospencer
approved these changes
Jun 30, 2025
Member
ospencer
left a comment
There was a problem hiding this comment.
This is useful, like you said, for abstract types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if you had the line
type A<a> = ait would cause the lsp to crash as we didn't handle the case of= ain oprint, this corrects the implementation to prevent the crash.I am slightly wondering if we should even allow this behaviour. I came across this behaviour with low level grain bassically taking advantage of it to create a completely abstract type and am only submitting a fix because nothing prevents a user from doing it currently however I don't really see any real world use case for this syntax.