feat(stdlib): Add Path.updateExtension#2282
Merged
ospencer merged 1 commit intoApr 23, 2025
Merged
Conversation
This adds `Path.updateExtension` so users can set the current extension. Edge Cases: * Regular, we just chop the extension and then append `.<ext>` to the end * Directory, we don't set the extension * Empty extension sets something like `file.ext` to `file.`, this seems weird but I think it's the best option if a user actually wants to clear the extension they should use `removeExtension`. Note: One thing I noticed is our examples for `Path` omit the `Path.` which means unless you do` use Path.*` (which I don't think we encourage) the examples are not runnable off the bat, I think we should fix this in a seperate pr for consistency across the stdlib.
Member
|
It'd be cool if @alex-snezhko could take a look at this. |
alex-snezhko
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
Path.updateExtensionso users can set the current extension.Edge Cases:
.<ext>to the endfile.exttofile., this seems weird but I think it's the best option if a user actually wants to clear the extension they should useremoveExtension.Note: One thing I noticed is our examples for
Pathomit thePath.which means unless you douse Path.*(which I don't think we encourage) the examples are not runnable off the bat, I think we should fix this in a seperate pr for consistency across the stdlib.