close
The Wayback Machine - https://web.archive.org/web/20190809204046/https://github.com/twitter/twurl/pull/91
Skip to content

/twurl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix token secret cli parsing #91

Merged
merged 1 commit into from Jul 5, 2018
+6 −1

Conversation

@woparry
Copy link
Contributor

commented Jun 20, 2018

Problem

twurl crashes with a confusing error like

0.9.3/lib/twurl/oauth_client.rb:138:in `gets': No such file or directory @ token_secret

when you supply the -S parameter to twurl authorize ie.

twurl authorize -c client -s client_secret -a token -S token_secret

because the -S parameter does not take an argument, even though the docs say it should

Solution

make -S take an argument (and test that we can parse the argument)

Result

it doesn't crash
@paradigmsort
fix token secret cli parsing
Loading status checks…
5610df3
@CLAassistant

This comment has been minimized.

Sign in to view
Copy link

commented Jun 20, 2018 •
edited

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@coveralls

This comment has been minimized.

Sign in to view
Copy link

commented Jun 20, 2018 •
edited

Coverage Status

Coverage increased (+0.2%) to 88.173% when pulling 5610df3 on woparry:op/fix-token-secret into d561e70 on twitter:master.

@andypiper andypiper self-assigned this Jun 23, 2018

@andypiper

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 3, 2018

Hi @woparry thanks for the PR - license helper is showing the CLA is not signed yet. If you could double-check, I can bring this in later today.

@andypiper andypiper self-requested a review Jul 3, 2018

@andypiper andypiper referenced this pull request Jul 3, 2018

Closed

modify token-secret not get problem. #69

@andypiper

andypiper approved these changes Jul 3, 2018
View changes

Copy link
Member

left a comment

Tested locally and LGTM. Thanks. Just waiting on CLA to come out of pending state.
@woparry

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 3, 2018

Thanks! I clicked on the link and it says "you have signed the CLA for twitter/twurl", but when I click "recheck" on this page nothing happens.
@andypiper

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 5, 2018

OK I'm going to go ahead and merge (but will not immediately make a new release) - need to look into this CLA thing, it might be broken.

@andypiper andypiper merged commit e4686b4 into twitter:master Jul 5, 2018
0 of 2 checks passed

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
license/cla Contributor License Agreement is not signed yet.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypiper andypiper

Assignees

@andypiper andypiper

Labels
None yet
Milestone
No milestone
5 participants
@woparry @CLAassistant @coveralls @andypiper @paradigmsort
You can’t perform that action at this time.