Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Reduce includes in auto_picture_in_picture_tab_helper.h
Forward declare in auto_picture_in_picture_tab_helper.h to reduce the
size of the header. Move the set_auto_blocker_for_testing() impl into
auto_picture_in_picture_tab_helper.cc to avoid needing to include
auto_pip_setting_helper.h.
Change-Id: I23b8ce29b50040ee21da0038d195c444b1428e07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8265946
Reviewed-by: Phil Yan <philyan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681026}
Remove BocaAppClient::GetIdentityManager() use from BocaSessionManager
Instead, pass the instance via ctor's param for better dependency
management.
Bug: 542786399
Test: Tryjob
Change-Id: I3c8d3a839423de37203b1c48634d66d41290231d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8260127
Reviewed-by: April Zhou <aprilzhou@google.com>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681025}
[PDF Ink Signatures] Fix italic string description
The description for the string incorrectly mentions "bold italic" when
it should be "italic font".
Change-Id: If83b733181e4497d516ba3c2cb7ada5f6e270973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8265825
Commit-Queue: Andy Phan <andyphan@chromium.org>
Auto-Submit: Andy Phan <andyphan@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681024}
[PDF Ink Signatures] Add operator== for InkTextBoxAttributes
Add equality operator and copy support for InkTextBoxAttributes and
migrate test assertions to compare attributes directly. Then remove
MATCHER_P10 in favor of using operator==.
GMock only supports up to MATCHER_P10. InkTextBoxAttributes currently
has 10 fields, so adding future attributes (like strikethrough) would
exceed this limit. Defining operator== allows tests to compare
attributes directly.
TAG=agy
CONV=f97f0674-ca92-4b13-b50c-fafdcfb0050e
Bug: 541374953
Change-Id: I6a2863dceb0e9929024418677a0e0b66fbfa366a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8244727
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681023}
[PDF Ink Signatures] Convert InkTextBoxAttributes to aggregate struct
Remove custom constructors and destructor from InkTextBoxAttributes,
making it an aggregate struct with default member initializers, and
migrate call sites to designated initializers.
This avoids constructor churn when adding operator== and future
attributes (i.e. in https://crrev.com/c/8244727 and
https://crrev.com/c/8261695).
TAG=agy
CONV=f97f0674-ca92-4b13-b50c-fafdcfb0050e
Bug: 541374953
Change-Id: Ic65455194c7f9b31a0410dd7982e86a4adeba6f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8262330
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681022}
Add ds_store and mac_alias to third_party
Add two third-party Python libraries from dmgbuild which faclitate the
programmatic creation of macOS .DS_Store files. These will be used to
modernize how Chrome creates these files for its DMG installers, which
currently require arcane knowledge and esoteric tools.
Bug: 542574504
Change-Id: Ic723f88e2fdda156f75e6e206da686779c564d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8244327
Reviewed-by: Deepak Ravichandran <deepakr@google.com>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/main@{#1681021}
Roll FuzzTest from a2937eabd54d to 8bc765afc32f (5 revisions)
https://chromium.googlesource.com/external/github.com/google/fuzztest.git/+log/a2937eabd54d..8bc765afc32f
2026-08-17 xinhaoyuan@google.com Remove the dispatcher prototype.
2026-08-17 theshank@google.com fuzztest-rust | support replaying corpus for inf
2026-08-17 theshank@google.com fuzztest-rust | Add clippy rules and fix stylistic lints across fuzztest-rust sub-crates
2026-08-17 theshank@google.com fuzztest-rust | Add support for listing crash IDs from the corpus database
2026-08-17 theshank@google.com cargo-fuzztest: support replaying corpus for a certain time
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuzztest-chromium
Please CC chrome-fuzzing-core@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-centipede-asan-rel;luci.chromium.try:linux-libfuzzer-asan-rel;luci.chromium.try:win-libfuzzer-asan-rel
Bug: None
Tbr: chrome-fuzzing-core@google.com
Change-Id: I96e14532e687861c11cddddb3b87ead20937c01c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8258542
Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1681020}
Roll ANGLE from c93844c75789 to b5e087aaabc6 (6 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/c93844c75789..b5e087aaabc6
2026-08-17 abdolrashidi@google.com Traces: Fix merging client array ranges of size 0
2026-08-17 abdolrashidi@google.com Improve UpdateUniformLocation() for upgrades
2026-08-17 a.annestrand@samsung.com OpenCL: introduce RefPointer::Create
2026-08-17 g.tammana@samsung.com CL/Vulkan: Arrange the device caps into categories
2026-08-17 a.annestrand@samsung.com OpenCL: Move spv reflection-parse/stripping to clspv_utils
2026-08-17 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from ab310674f018 to 9bf510cf5d65 (971 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-mac-arm64;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-win-arm64;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I44115c70a146a7dde8881a5ea47923f97ba3c6f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8266027
Commit-Queue: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1681019}
[PWA] Fix widget waiter flake in WebAppIntegrationTestDriver::LaunchFile
In WebAppIntegrationTestDriver::LaunchFile(),
AwaitAllCommandsCompleteForTesting() was called immediately after
browser_creator.Start(). For tests expecting a file handler launch
dialog (LaunchFileExpectDialog), no web app command is queued yet until
the user decision dialog completes. Invoking
AwaitAllCommandsCompleteForTesting() can pump nested event loops and
race with widget creation and retrieval in NamedWidgetShownWaiter,
causing widget != nullptr assertion failures.
Synchronization is already handled by NamedWidgetShownWaiter and
web_app::startup::SetStartupDoneCallbackForTesting. Removing the
premature AwaitAllCommandsCompleteForTesting() matches Mac behavior and
resolves the flake.
Fixed: 545879103
Change-Id: Idddb8c985540f449e0940c472a8559b3ca6ec10f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8262280
Auto-Submit: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681018}
extensions: Do not dismiss popup on inside touch
`setDismissOnTouchInteraction(true)` is intended for ephemeral
tooltips/IPH and causes any tap inside the popup to dismiss it if not
synchronously consumed by an Android child view. In the ContentView,
touch events are dispatched asynchronously to WebContents, so this
caused any touch inside the WebContents to dismiss the popup window.
Bug: 543589144
Change-Id: I6c9b296a104ffcd7e968a143c151cee8b194fced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8259374
Commit-Queue: Masa Fujita <massan@google.com>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681017}
Refactor ReadAnythingUntrustedPageHandler test
In preparation for removing the immersive flag.
Bug: 537491063
Change-Id: I12d5722c63fe61f866876f46df71cec6bc536840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8233819
Commit-Queue: Lauren Winston <lwinston@google.com>
Reviewed-by: MartÃn Gómez <martinglopez@google.com>
Cr-Commit-Position: refs/heads/main@{#1681016}
[glic] Do not show Open Gemini context menu item for standalone images
This CL updates ContextMenuContentType::SupportsGroupInternal for
ITEM_GROUP_GLIC to return false when invoked on an image media context
without text selection (has_selection || !SupportsGroupInternal(ITEM_GROUP_MEDIA_IMAGE)).
Bug: 516829938
Change-Id: I2aca0bf95d19bd774c1d4be9786cbe679ebb688b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8224767
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sana Akbani <sanaakbani@google.com>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Basia Zimirska <basiaz@google.com>
Cr-Commit-Position: refs/heads/main@{#1681015}
Roll Help App from hMXjrFyvhl5u_ZQvc... to 1Gds_6BMdRWWurC2E...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202608170800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/1Gds_6BMdRWWurC2EZMnzfbAahONd_JrNdhzrVAXlmkC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC cros-essential-apps-dev@chromium.org,help-app@grotations.appspotmail.com,jomag@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: Ib3143dc9069f54bf33c37441f8d3cc85fdea3b76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8263691
Bot-Commit: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1681014}
[APC] Clarify required intersection lifecycle state
LocalFrameView::kRequired already suppresses render throttling until
the document reaches kPrePaintClean. Three comments still said or
implied that the override stopped at kLayoutClean.
Correct the comments in the state declaration, lifecycle invariant,
and throttling test. Strengthen the existing DCHECK to match the
pre-paint-clean contract. This does not change production behavior.
The existing ThrottlingOverrideOnlyAppliesDuringLifecycleUpdate test
verifies that the required view reaches kPrePaintClean and then
throttles again after the lifecycle update.
Bug: 463451588
Change-Id: I4a92bc07ba2bd1dd4d55e0be0c6efeb054ceed55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8263194
Commit-Queue: Aaron Leventhal <aleventhal@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681013}
[bedrock] Remove Browser* dependencies from four desktop unit test suites
Refactors unit tests across four desktop suites to remove Browser* and
TestBrowserWindow dependencies for Project Bedrock:
1. c/b/ui/views/bookmarks/bookmark_bar_view_unittest.cc:
- Decouples BookmarkBarViewWithCounter from Browser and
TestBrowserWindow using MockBrowserWindowInterface.
- Updates constructor to accept BrowserWindowInterface*.
- Prunes unused browser.h, create_browser_window.h, and
test_browser_window.h.
2. c/b/apps/app_shim/app_shim_manager_mac_unittest.cc:
- Replaces TestBrowserWindowShow (subclassing TestBrowserWindow)
with TestBaseWindowShow directly implementing ui::BaseWindow.
- Prunes unused test_browser_window.h.
3. c/b/ui/views/site_data/page_specific_site_data_dialog_unittest.cc:
- Removes orphaned browser_with_test_window_test.h include.
4. c/b/ui/views/webid/fedcm_account_selection_view_desktop_unittest.cc:
- Removes orphaned browser_with_test_window_test.h include.
TAG=agy
CONV=a89fc9fb-6826-4862-9b08-55f05a3a432a
Bug: 543043111
Change-Id: I1b6229d9afb70aef910cfd0340be3ccd2f801c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8259557
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/main@{#1681012}
Roll eigen from 14d33f2f2ec9 to 76a7c53018c3 (1 revision)
https://chromium.googlesource.com/external/gitlab.com/libeigen/eigen.git/+log/14d33f2f2ec9..76a7c53018c3
2026-08-17 4643818-rmlarsen1@users.noreply.gitlab.com Core: Make structured-bindings tuple_size SFINAE-friendly for dynamic sizes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/eigen-chromium
Please CC chrome-intelligence-core@google.com,zekunjiang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in eigen: https://gitlab.com/libeigen/eigen/-/issues
To file a bug in Chromium: https://b.corp.google.com/issues/new?component=1405550
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:optimization_guide-linux;luci.chrome.try:optimization_guide-mac-arm64;luci.chrome.try:optimization_guide-mac-x64;luci.chrome.try:optimization_guide-win32;luci.chrome.try:optimization_guide-win64
Tbr: zekunjiang@google.com
Include-Ci-Only-Tests: chromium.android:android-pie-arm64-rel|android_browsertests
Change-Id: I9a70df9301786971aca7f84f910b19354a458634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8262220
Commit-Queue: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1681011}
[Glic] Add voice permission snackbar strings
Usage will be added later. String is needed before branch point.
UX: https://docs.google.com/presentation/d/1uN6jAfemLZ5Gfj2znSpFZvJThf6VQui_sZ2IBit1zMA/edit?usp=sharing
Bug: 545727652
Change-Id: Iaed36378a7840c6046b10f949da250b553fd7828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8253627
Reviewed-by: Ritika Gupta <ritikagup@google.com>
Commit-Queue: Ritika Gupta <ritikagup@google.com>
Auto-Submit: Hailey Wang <haileywang@google.com>
Commit-Queue: Hailey Wang <haileywang@google.com>
Cr-Commit-Position: refs/heads/main@{#1681010}
Roll Perfetto from 030b19d1fb94 to da65f7e907e0 (3 revisions)
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/030b19d1fb94..da65f7e907e0
2026-08-17 lalitm@google.com perfetto: uprev clang to Chromium latest version (#7118)
2026-08-17 runpinglai@google.com tp: make Wattson TPU frequency slices gapless across trace (#7104)
2026-08-17 lalitm@google.com ai: improve skill by adding various important notes (#7115)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC eladalon@google.com,perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:546666978
Tbr: eladalon@google.com,perfetto-bugs@google.com
Test: Test: tp diff test and ui test
Change-Id: Ifab7df1b0f5343edbf7eba38112c65a4af498963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8266026
Commit-Queue: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1681009}
[media] Switch seek-to-duration web tests to WebM/Opus
To prevent test flakiness and timeouts caused by Ogg Vorbis container
duration vs. discard padding discrepancies introduced during FFmpeg M153
rolls (r1678540), switch the video source for seek-to-duration web tests
to WebM/Opus.
- Copy external/wpt/media/test.webm (VP9/Opus) to:
http/tests/media/resources/test.webm
- Update video.src in both seek-to-duration tests.
- Remove timeout expectation for video-seek-to-duration-with-playbackrate-zero.html
from TestExpectations.
Bug: 546765335
Change-Id: Ib8a65dab57f640f6183f2a560e4996a4a34d68b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8258319
Reviewed-by: Jordan Bayles <jophba@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681008}
[Extensions] Run some webRequest tests in both dispatch modes
Run webRequest browser tests with kWebRequestPerContextEventDispatch
both enabled and disabled:
- Parameterize various tests using base::test::WithFeatureOverride.
In particular, make listener count checks reflect the active mode.
- Run WebRequestCORSWithExtraHeaders in fixtures that pin each
dispatch mode.
- Run the EventRouter content-script exploit test in both modes using
the correct event names. Add tests verifying that registering an
event name from the wrong protocol terminates the renderer.
- Split webRequest dispatch metrics tests into legacy and per-context
suites to verify that active listeners only record dispatch-to-ack
metrics under DispatchEventToProcess().
- Move WebRequestBlocking_MismatchedLazyReregistration to a legacy only
fixture, as stale sub-event registrations only occur under legacy
dispatch.
Bug: 494684626
Change-Id: Ife523a3076c58a8e19f69e3a0f37ee80ae6939d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8262229
Commit-Queue: Andrea Orru <andreaorru@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681007}
[Extensions] Restore webRequest CORS preflight expectations
testCorsPreflightWithExtraHeaders (webrequest/test_cors) stopped after
the preflight's onResponseStarted event. https://crrev.com/c/1973442
removed expectations for the preflight's onCompleted and the actual
request's onErrorOccurred because the test also ran with CORS in Blink.
In that mode, the renderer canceled the preflight after its own CORS
check, making the arrival order of onCompleted vs. onErrorOccurred racy.
With CORS handled in the network service, the browser dispatches
onResponseStarted and onCompleted together once the preflight's response
headers are handled (in WebRequestProxyingURLLoaderFactory). The network
service then performs the CORS check and fails the actual request with
net::ERR_FAILED.
This CL restores the missing expectations, ensuring the subtest waits
for the full request chain to complete before subsequent tests register
listeners on the same URL.
Also drop the unused async keyword from the test runner.
Bug: 40105656
Change-Id: Ief85f774f3e4ca3d11dc91e2661bcc1819fbb938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8262045
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Andrea Orru <andreaorru@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681006}
Roll Perfetto Trace Processor Linux from 0b6a9e903823 to 030b19d1fb94
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/0b6a9e903823..030b19d1fb94
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Id5b6a033f2b491b3187de32cbc0d495130e29a9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8262247
Commit-Queue: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1681005}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1786996783-b2e39ed4fec1ed7493e791bb6b9277f7e1b3890d-5ff293132ad9852cce48054c161e8d78e04a9cfc.profdata to chrome-mac-arm-main-1787003984-7282dd728f798268bfa716f66b1237bd0f83c54b-721c937de613bd50bc69309714408a2a0f3cf2af.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Iaf5ce3131065170ec3186457c4928c7ec42264bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8265791
Commit-Queue: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1681004}
Parameterize tests in safe_browsing_service_browsertest to run v4/v5
This includes adding another CacheArtificialV5SearchHashesLookupVerdict
method in V5SearchHashesCache to be able to cache specific threat types
for end-to-end lookups in the browser tests.
Bug: 362791941
Change-Id: I4a072be629fb51fe32163815ea6dff03fe94fd2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8199511
Commit-Queue: thefrog <thefrog@chromium.org>
Reviewed-by: Anunoy Ghosh <anunoy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681003}
Roll clusterfuzz-data from 1b057717eb51 to 85d23a9833c8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clusterfuzz-data-chromium
Please CC chrome-fuzzing-core@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in clusterfuzz-data: https://g-issues.chromium.org/u/0/issues/new?component=1518380&template=0
To file a bug in Chromium: https://g-issues.chromium.org/u/0/issues/new?component=1518380&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Change-Id: Ided823253341dc7157c30d55f8adb60a010b23b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8263889
Bot-Commit: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1681002}
Allow no-op (no features) runtime mutable experiments
Allowing no-op studies can be useful for monitoring, evaluating
saturation time of runtime mutability, etc.
NO_IFTTT=N/A
Bug: 536851765
Change-Id: Ie9703c5bb2218a98303120f28674a084dd840a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8212789
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Luc Nguyen <lucnguyen@google.com>
Cr-Commit-Position: refs/heads/main@{#1681001}
[focusgroupV2] Test feed keyboard navigation
Add WPT coverage for Focusgroup V2 feed navigation, including arrow
navigation, hard boundaries, reading-flow order, dynamic updates, nested
feeds, and noitemcontrols.
Explainer: https://open-ui.org/components/focusgroup-v2.explainer/#feed-focusgroups
Bug: 445992558
AX-Relnotes: n/a.
Change-Id: Ia7a835d9f5d9952f0be2db2b266cb10ff5bdba96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8246500
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1681000}
Rename KiBU / MiBU etc. to KiB / MiB and update callers in base/
The old names are left as an alias until all call sites are updated.
base/byte_size.h was edited by hand, then the rest of base/ was updated
with
git grep -l [KMGTPE]iBU|grep -v byte_size.h|xargs sed -i
"s/\([KMGTPE]\)iBU(/\1iB(/g"
NO_IFTTT=No changes to SysUtils.java needed
Bug: 448661443
Change-Id: I7f1c65cd32203ad1be600822529f4960f7de5e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8203066
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680999}
Make chrome://omnibox/aim-eligibility autocomplete in the omnibox.
I don't know why, but "eligibility" is really hard to type.
Change-Id: Ie54e436218f7df9bcfc81e4623eb0b8e7ed3a4cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8257474
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680998}
Extend histogram expiry for Ash.Login.ShowGaiaSignin.PermanentlyUntrusted
Extend the expiry date from 2026-10-01 to 2027-04-01 (6 months) to
ensure continued data collection.
Bug: 547910410
Test: CQ
Change-Id: Ife88ecdcdc51cffeaee1709f41f14a9ab4570983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8258444
Reviewed-by: Jun Ishiguro <junis@google.com>
Auto-Submit: Longbo Wei <longbowei@google.com>
Commit-Queue: Jun Ishiguro <junis@google.com>
Cr-Commit-Position: refs/heads/main@{#1680997}
[loomnibox] Route query to AI Mode when clicking AI mode button
see
https://screencast.googleplex.com/cast/NDgwMzYxMDczMzk2OTQwOHw2NzkzYmNmNC1lMA
Fixed: b:543930630
Change-Id: Ia280da1f1f315b393df40941dfb5beffe8c7604e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8253991
Reviewed-by: Nihar Majmudar <niharm@google.com>
Commit-Queue: Juliet Lévesque Knighton <julietlevesque@google.com>
Cr-Commit-Position: refs/heads/main@{#1680996}
Print Preview: Refactor some list item styles
This is in preparation for adding some forced colors handling.
Bug: 485298242
Change-Id: I24b3864ceab5b71989bfaf9da2ba70f55901136c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8261729
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: April Kallmeyer <ask@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680995}
[Tab Switcher] Provide visible focus indication on selected tab action buttons
Use small_icon_background_on_primary for selected non-incognito tabs so
the focused outline is drawn with colorOnPrimary, providing
high-contrast keyboard focus indication.
Demo: http://screencast/cast/NDk2NTYwNjE4ODEyMjExMnxmZmQ5ZTRkNC0zMA
Fixed: 482102716
Change-Id: I6c0a5bb3fceeba84f8659c4662b9bf86b35eebf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8258954
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Madhav Pruthi <madhavpruthi@google.com>
Cr-Commit-Position: refs/heads/main@{#1680994}
[Enterprise Skills] Implement V2 webview bridge API for enterprise skills
Wires enterprise skills between the Chrome C++ browser backend and the
V2 remote webview guest frame via Mojo and postMessage bridge APIs.
- Mojo API (skills.mojom): Adds SkillsPageV2 and extends
SkillsPageHandler with SetPage, GetProvidedSkill, and
GetProvidedSkills.
- C++ Page Handler (SkillsPageHandlerV2): Implements
SkillsService::Observer to observe OnProvidedSkillsChanged and push
live provided skill updates to the V2 webview remote.
- TS Webview Bridge (skills_webview_bridge.ts): Adds tightly scoped
message handlers for SKILLS_GET_PROVIDED_SKILL and outbound
postMessage dispatchers for SKILLS_SEND_PROVIDED_SKILLS_TYPE and
SKILLS_PROVIDED_SKILL_INFO_TYPE. Strips prompt payload data natively
via SkillPreview interface mapping.
- TS Webview (skills_webview.ts): Implements SkillsPageV2Interface to
bind the SkillsPageV2Receiver and dispatch provided skills on
completion of page load.
- Testing: Comprehensive unit test coverage in SkillsPageHandlerV2Test
and SkillsWebviewBridgeTest.
context: enterprise-configured-skills-dd
Low-Coverage-Reason: TRIVIAL_CHANGE Passthrough logic to Mojo bindings in skills_webview.ts.
Bug: 538249825
Change-Id: Ie8f5ae3c72cecf21006b6f8f4d6f898e7ed95399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8223948
Reviewed-by: Austin Zhang <austinzzr@google.com>
Reviewed-by: Salma Elmahallawy <esalma@google.com>
Commit-Queue: Austin Zhang <austinzzr@google.com>
Commit-Queue: Rafay Bughio <rafayb@google.com>
Auto-Submit: Rafay Bughio <rafayb@google.com>
Cr-Commit-Position: refs/heads/main@{#1680993}
[iOS][NTPRedesign] Make NTP margins 16pt
This change makes the NTP margin 16pt when kNewTabPageUICleanup is
enabled. Constraints for the NTP modules are updated to maintain the
intended padding based on the new margins.
This change also updates `FeedHeaderViewController` to still create the
feed header even if the title is hidden. This ensures the top padding of
the Discover feed is accurate.
New Margins on iPhone:
http://screencast/cast/NjA4NDk2MzU1OTUzODY4OHw3M2I4NzI1OS00Zg
Lanscape: http://screencast/cast/NjA4OTgxMDIyODgwNTYzMnxhMzg0MDY4Ny01Mw
iPad: http://screencast/cast/NjYwMDUwOTc4Mjc1MzI4MHwzMTJlMTIzMC05Yw
Fixed: 545560669
Change-Id: I6ae7c5a09f3e22814ecdf0bd60ef8a06d8015457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8257188
Commit-Queue: Briana McClure <bmcclure@google.com>
Reviewed-by: Chris Lu <thegreenfrog@google.com>
Cr-Commit-Position: refs/heads/main@{#1680992}
Fix iOS crash on `LoadAndVerifyModelOffThread`.
Crash link: http://crash/b2bd9a2470400000
`PassageEmbedderModelLoader` is the only caller to
`AddObserverForOptimizationTargetModel` that passes a non-background
task runner and is likely root cause of the crash.
Bug: 548000861
Change-Id: I20a9a981ef1251a5fff10afb0037a81545c15a2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8266226
Reviewed-by: Adam Arcaro <adamta@google.com>
Commit-Queue: Zekun Jiang <zekunjiang@google.com>
Cr-Commit-Position: refs/heads/main@{#1680991}
Settings Lit: Migrate people_page/, part 9
In this part migrating sync_page.
Bug: 393471368
Change-Id: I728b21589a822dd707c4135616ba65966d6951ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8252872
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680990}
Return by const ref in RecordContentToVisibleTimeRequest mojom traits
Returning by value creates a temporary that is immediately discarded
after the bytes are written to the wire; this is wasteful since the
type in question is not consumed during serialization.
Bug: 546207269
Change-Id: I7cb3febb9af2946827544911cc56f314ac7a5032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8260082
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1680989}
Remove UpdateClient.CupFallbackToEtag2
We have determined that the CUP proof is virtually never used from the
ETag header. We no longer need this metric.
OBSOLETE_HISTOGRAMS=No longer needed. See issue 541374781
Bug: 541374781
Change-Id: Ib0e0fd39eaad9a80b75ca49e3fc848646a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8258340
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/main@{#1680988}
Add TabClosureCommittedMethodRefactor flag on Android.
This CL introduces the TabClosureCommittedMethodRefactor feature flag, including its metadata, descriptions, and Java CachedFlag representation. This flag will be used to gate the refactored tab closure committed methods on Android.
Bug: 547870459
Change-Id: I5f2762b72b66eea04b830bf1336e39e8ad133e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8253423
Commit-Queue: Hitarth Kothari <hitarthkothari@google.com>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Auto-Submit: Hitarth Kothari <hitarthkothari@google.com>
Reviewed-by: Hitarth Kothari <hitarthkothari@google.com>
Cr-Commit-Position: refs/heads/main@{#1680987}
Remove BEGIN EXCLUSIVE from WebDatabase::Init
WebDatabase::Init was manually checking whether the database was
writable by opening and closing an exclusive transaction. This code was
added in https://crrev.com/c/4470168 with a comment saying that the code
should be removed after crbug.com/1430313 is fixed. This bug was since
closed as Obsolete.
The condition is misleading because on failure, it logs a
kDatabaseLocked histogram, which is possibly not the right diagnostics.
The test InitFailureDatabaseLocked in web_database_unittest.cc shows
that kDatabaseLocked can logged if trying to initialize a database when
the disk is full. Disk full errors being very common in the population,
it's possible for this to be more prevalent than external processes
holding a lock on the database.
Without the `BEGIN EXCLUSIVE`, the error would surface later, when
initializing the meta table for instance. The correct way of improving
error diagnosing from there would be to additionally log the underlying
SQLITE error causing the failure (SQLITE_BUSY, SQLITE_FULL,
SQLITE_IOERR, etc.)
Now, creating a transaction manually like this is a problem because it
prevents sql/ owners from doing several improvements:
- We'd like to implement transaction nesting via SAVEPOINTs, but this
can't work if clients manually create transactions via statement
execution.
- We'd like to replace global transactions with a natively supported
batching mode, but this can't work if clients create transactions
manually.
- Transactions can easily be misused (e.g. they can be rolled back at
any time by statement errors). Our goal is for the `Transaction`
abstraction to provide a safe mechanism handling all corner cases and
we'd like to block Database clients from manually creating
transactions (e.g. using a presubmit, like in [1]).
[1]:
https://crsrc.org/c/PRESUBMIT.py;l=1732-1748;drc=c8c5a6a954922aeea94f9f2f97e74b1180087d80
Bug: 541287627, 541310265
Change-Id: I3489d481951201d63c60657b433734eca9e64b4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8177739
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680986}
fuzzing: Fix Swift compilation errors in generated Fuzzilli profiles
This CL fixes two Swift compilation errors in generated Mojo Fuzzilli
1. Removes the `static` modifier from `mojoPrefix` in
`fuzzilli_profile.tmpl` because file-scope declarations in Swift
cannot be marked `static`.
2. Fixes `elementGroupName` in `arrays.tmpl` to access `.name` directly
on the `ObjectGroup` rather than `.group.name`.
profiles:
Bug: 479225939
Change-Id: I3137f712e045576524d12be77fb2ff2fb05bce9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8264091
Commit-Queue: Tigran Bantikyan <bantikyan@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680985}
[glic] Delete obsolete testNoExtractionWhileHidden test
Deleted testNoExtractionWhileHidden from legacy CC and TS. Verified via
code search in glic_sharing_manager_impl.cc that the Glic host handler
no longer performs panel-active or hidden gating for context extraction
(it only validates tab focus, pinning, and tab-context permission
state). Since the background gating was removed from the backend, the
test is no longer applicable.
Also removed the legacy preloading test suite class
(DISABLED_GlicApiTestWithOneTabAndPreloading) and its instantiation
since all tests in the suite have now been cleaned up/deprecated.
Bug: b:477918640
Change-Id: Ifa44ecfea141d9e9e564faded1f2f42d6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8254153
Commit-Queue: Bryant Chandler <bryantchandler@chromium.org>
Reviewed-by: Nick Birnie <birnie@google.com>
Cr-Commit-Position: refs/heads/main@{#1680984}
Remove unreachable code in WebDatabase::Init
WebDatabase::Init has a condition for aborting initialization if the
version on disk is too new. This code is unreachable because a call to
RazeIfIncompatible is done right before, which razes the database on the
exact same condition.
The histograms on UMA confirms that the enum kCurrentVersionTooNew is
never recorded.
Bug: 541287627, 541310265
Change-Id: I5e41b5ae0ed573bdfc9c5705ecdb7a5eb1204903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8183010
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680983}
[TWA] Fix file handling regression by checking permissions in trampoline
The TWA file handling path regressed because strict caller permission
checks (using Activity.getCurrentCaller() on Android 15+) returned
Chrome's UID due to the trampoline launch. The fallback session check
using checkUriPermission failed for transient URI permissions because
the TWA activity had often finished by the time the check ran.
This CL fixes this by performing the permission check in the trampoline
activity (LaunchIntentDispatcher) where the TWA is still alive. The
verified file data and write permissions are stashed in the launch
intent, which is marked as trusted. WebAppLaunchHandler then uses
these stashed results if the intent is trusted.
Fixed: 540028201
TAG=agy
CONV=d8f0b4ab-dcd5-404c-8aff-bd4906162ced
Change-Id: Ib8c77dbe77dd59a4214a8ca43c7a2473107c4a8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8212644
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680982}
Migrate base/test_suite to use ScopedDefaultIcuLocale
This is a bigger effort to concentrate icu locale setting with the
long-term goal of separating ICU locale vs UI strings locale.
Change-Id: Ib38842ba19973f99733a634c1c30add517a5f8af
Bug: 542711615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8265206
Commit-Queue: Danilo Tedeschi <danft@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680981}
[glic] Delete obsolete testDeferredFocusedTabStateAtCreation test
This test verified focused tab state buffering/suppression when Glic is
preloaded (created in background before showing). Since Glic instances
are never created before they are shown, this test is no longer needed.
Bug: b:477918640
Change-Id: I938f0b74bdeeb559118301c0e77eb0e06a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8254152
Reviewed-by: Nick Birnie <birnie@google.com>
Commit-Queue: Bryant Chandler <bryantchandler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1680980}
Revert "[Omnibox] Migrate AutocompleteMediator to @TriState"
This reverts commit 626e7afa47443efd098df5ae005c52df003326f1.
Reason for revert: tribool adds a "take-a-pick" blind spot that is problematic to detect and respond to timely. our code intentionally crashes where it does with null, and intentionally manages null cases. the tribool adds a blind spot - what does it mean `== true`? even worse: what does it mean `!= true`?
Boolean.TRUE.equals() pattern enforces a positive matching: value _must_ be `TRUE` and nothing else. the tribool makes it convenient to add negative matching that can mean anything depending on the context, leading to ambiguous code behavior: the same class may do both (via, say, automated code conversion)
`if (oldbool) {}` ⮕ `if (newbool == TRUE) {}`
and
`if (!oldbool) {}` ⮕ `if (newbool != TRUE) {}`
and end up in a bizarre state.
Please don't add this to the Omnibox code.
Original change's description:
> [Omnibox] Migrate AutocompleteMediator to @TriState
>
> Bug: 545986483
> Change-Id: Icf4329d5b0ae2c481977d29486c994828114f4e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8257372
> Commit-Queue: Fiaz Muhammad <mfiaz@google.com>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1679551}
Bug: 545986483
Change-Id: I2177ac7905b11dc6b811f6aa522affe5c14db49a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8265546
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/main@{#1680979}
Clean up header definition for deleted TrackingProtection function
Change-Id: I7f7186829bd267457f09f8b92c0e22901642ad9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8263630
Reviewed-by: Kevin Graney <kmg@google.com>
Auto-Submit: Fiona Macintosh <fmacintosh@google.com>
Commit-Queue: Kevin Graney <kmg@google.com>
Cr-Commit-Position: refs/heads/main@{#1680978}
[glic] Migrate testSingleFocusedTabUpdatesOnTabEvents to new_glic_api_browsertest
Bug: b:477918640
Change-Id: Ia019efc084b5559527419d21ddea35dc6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8258352
Commit-Queue: Bryant Chandler <bryantchandler@chromium.org>
Reviewed-by: Nick Birnie <birnie@google.com>
Cr-Commit-Position: refs/heads/main@{#1680977}
