Install pkgconfig only if module is built#3451
Merged
Merged
Conversation
ead66e1 to
48f7d37
Compare
48f7d37 to
31f426c
Compare
ChrisThrasher
approved these changes
Mar 1, 2025
7 tasks
Contributor
|
This PR has caused a regression.
|
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another upstream fix that was patched in vcpkg. Currently SFML always installs all pkgconfig files, even if you don't build for example sfml-audio. Moving the install command into the
Macros.cmakeshould make sure that they're only installed if the module is also built.This PR is related to the issue microsoft/vcpkg#42913
Tasks
How to test this PR?
Install SFML on a platform supporting pkgconfig and don't build one module. the sfml-all.pc and the specifically deselected sfml-module.pc should not be installed.