Default to building static libraries#2646
Conversation
See SFML#2389 for full rationale
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2646 +/- ##
========================================
Coverage 30.65% 30.65%
========================================
Files 229 229
Lines 19748 19748
Branches 4723 4723
========================================
Hits 6053 6053
+ Misses 13055 12944 -111
- Partials 640 751 +111 see 50 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| # disable static libraries on Android | ||
| if(SFML_OS_ANDROID) | ||
| set(BUILD_SHARED_LIBS TRUE) | ||
| endif() |
There was a problem hiding this comment.
I dug back in the commit history to find where this was added. I'm not totally sure why we have this here. Anything related to cross compilation belongs in a toolchain file. For what it's worth the Android CI jobs still succeed even if we remove this and build them as static libraries. Hopefully someone can point me to some Android docs explaining this requirement so I can add that link to the comment.
f4ad49e to
b23c514
Compare
b23c514 to
f4ad49e
Compare
Description
Closes #2389
I've looked around at a few CI jobs and they seem to be behaving the same as before. If any jobs are broken it would be the jobs that aren't part of the core build matrix.