close
Skip to content

Upgrade to CMake 3.22#2543

Merged
ChrisThrasher merged 1 commit into
SFML:masterfrom
ChrisThrasher:cmake-3.22
May 13, 2023
Merged

Upgrade to CMake 3.22#2543
ChrisThrasher merged 1 commit into
SFML:masterfrom
ChrisThrasher:cmake-3.22

Conversation

@ChrisThrasher

Copy link
Copy Markdown
Member

Description

Closes #2511

@ChrisThrasher ChrisThrasher added this to the 3.0 milestone May 8, 2023
@codecov

codecov Bot commented May 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2543 (94d4fce) into master (c45f637) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2543   +/-   ##
=======================================
  Coverage   27.29%   27.29%           
=======================================
  Files         228      228           
  Lines       19642    19642           
  Branches     4711     4711           
=======================================
  Hits         5361     5361           
  Misses      13803    13803           
  Partials      478      478           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45f637...94d4fce. Read the comment docs.

@ChrisThrasher

ChrisThrasher commented May 8, 2023

Copy link
Copy Markdown
Member Author

Some of the extended CI jobs are failing because they only have 3.18.4 installed. @binary1248 how hard is it to get a newer CMake version on those machines?

@eXpl0it3r

Copy link
Copy Markdown
Member

I upgraded CMake on my Raspberry Pi: https://snapcraft.io/install/cmake/raspbian

@binary1248

Copy link
Copy Markdown
Member

All builders should be upgraded now.

For reference if it is too hard to get a newer CMake somewhere you can always build it using the existing one:

sudo apt install libssl-dev
wget https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3.tar.gz
tar xzf cmake-3.26.3.tar.gz
cd cmake-3.26.3/
cmake .
make -j5
sudo make install
hash -r
cmake --version

@ChrisThrasher

Copy link
Copy Markdown
Member Author

The raspbian job still needs it's CMake updated

@eXpl0it3r

eXpl0it3r commented May 12, 2023

Copy link
Copy Markdown
Member

All builders should be upgraded now.

@binary1248 Your RaPi is still finding CMake 3.18 in its path somehow.

@binary1248

Copy link
Copy Markdown
Member

Should be fixed now.

@ChrisThrasher ChrisThrasher requested a review from eXpl0it3r May 13, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Raise minimum CMake version to 3.22

3 participants