Make 'Color' constants 'constexpr' and add tests#1937
Conversation
670fed1 to
93d777d
Compare
|
@Bromeon: this is what I meant... I remembered trying this, but VS2017 is broken :/ |
|
@Bromeon @binary1248 @eXpl0it3r: how do you feel about dropping VS2017 support? It is clearly broken... |
Ping :) |
|
Given that 2017 lies now half a decade in the past, I think it's OK to drop support for VS 2017, especially if it struggles to be C++17 compatible. It's of course a question if this can be worked around somehow (with reasonable effort). |
|
Well we knew going in, that we'll have to abandon some compilers. So that's fine for me. Wondering if we can easily do some branch filtering in Build Bot or drop VS 2017 for 2.6.x as well 🤔 |
|
The windows-2016 image is deprecated and will be removed in March 2022 anyways, so GitHub Actions couldn't easily cover VS 2017, see https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022/ |
93d777d to
b199000
Compare
|
@eXpl0it3r: it seems CI still tries to compile against VS2017. Is there a PR for the removal of this compiler? |
|
No, I didn't do anything. If we all agree, I can create one. |
|
Is this PR unblocked now that VS 2017 has been removed? |
b199000 to
7d278bc
Compare
|
CI passes now. @Bromeon @eXpl0it3r happy to approve? |
Description
Follow-up to #1904, using @Bromeon's suggestion to make constants
constexpr, and also added some tests.Tasks
How to test this PR?
CI.