ANativeActivity_onCreate is not exported in sfml-main (fixes #1457)#1460
Merged
eXpl0it3r merged 1 commit intoJul 28, 2018
Merged
Conversation
MarioLiebisch
approved these changes
Jul 28, 2018
MarioLiebisch
left a comment
Member
There was a problem hiding this comment.
Looks fine, get it merged as soon as possible together with #1458. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fixes issue #1457
The
ANativeActivity_onCreatefunction is not exported inlibsfml-example.sosodlsymwill either return NULL or recursively call the one fromsfml-activity(if sfml-activity is being used to load ANativeActivity_onCreate).Without this fix, SFML doesn't seem to run on android.