close
Skip to content

[iOS] Modernize toolchain file#1411

Closed
Ceylo wants to merge 1 commit into
SFML:masterfrom
Ceylo:feature/ModernizeiOSToolchain
Closed

[iOS] Modernize toolchain file#1411
Ceylo wants to merge 1 commit into
SFML:masterfrom
Ceylo:feature/ModernizeiOSToolchain

Conversation

@Ceylo

@Ceylo Ceylo commented Apr 8, 2018

Copy link
Copy Markdown
Contributor
  • Unused BUILD_ARM64 variable is removed
  • Support for Xcode < 4.3 (!!) is removed
  • Renamed all variables prefixed with CMAKE_
  • Made the toolchain file much less verbose (you still get the SDK being used and you can check other values from CMake cache displayed in CMake GUI)

If CI build is ok this should be ok. There is no expected side effect on SFML behavior itself.

…4.3 and don't pretend defining official CMake variables
@JonnyPtn

JonnyPtn commented Apr 9, 2018

Copy link
Copy Markdown
Contributor

Looks good to me

@Ceylo Ceylo changed the title Modernize iOS toolchain file [iOS] Modernize toolchain file Apr 12, 2018
@eXpl0it3r eXpl0it3r modified the milestones: 2.6, 2.5 Apr 14, 2018
@eXpl0it3r eXpl0it3r modified the milestones: 2.5, 2.6 May 9, 2018
@eXpl0it3r eXpl0it3r modified the milestones: 2.6, 2.5.1 May 17, 2018
@eXpl0it3r

Copy link
Copy Markdown
Member

Despite this being tagged as feature, do you think we could add this to SFML 2.5.1?

@JonnyPtn

Copy link
Copy Markdown
Contributor

I think that would be fine

@eXpl0it3r

Copy link
Copy Markdown
Member

Merged in ff011dc

@eXpl0it3r eXpl0it3r closed this Jun 4, 2018
@eXpl0it3r eXpl0it3r mentioned this pull request Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants